Merged
Conversation
Member
manuzhang
commented
Mar 11, 2024
manuzhang
commented
- Fix internal links
- Remove period in title
- Fix numbered list with code blocks
- Add identifier fields as an approach for upsert mode
1. Fix internal links 2. Remove period in title 3. Fix numbered list with code blocks 4. Add identifier fields as an approach for upsert mode
nastra
reviewed
Mar 11, 2024
nastra
reviewed
Mar 11, 2024
Member
Author
|
@nastra This is how the numbered list with code blocks look like without indentation 
|
Contributor
|
@manuzhang is it then correctly intended with your changes? Can you post a screenshot please? |
Member
Author
|
Here it is. 
|
nastra
approved these changes
Mar 11, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
1. Fix internal links 2. Remove period in title 3. Fix numbered list with code blocks 4. Add identifier fields as an approach for upsert mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.